-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add commonly used configurations to global scope #14406
Open
RotemCDos
wants to merge
18
commits into
grafana:main
Choose a base branch
from
Observabiliteam:feat/global-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged loki/main
…am/loki into feat/global-config
Kubernetes Manifest Diff SummaryScenario: default-single-binary-values (Added: 0, Modified: 11, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/query-scheduler/deployment-query-scheduler.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/query-scheduler/deployment-query-scheduler.yaml 2024-10-07 13:46:19.304235572 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/query-scheduler/deployment-query-scheduler.yaml 2024-10-07 13:46:21.506246907 +0000
***************
*** 49,54 ****
--- 49,56 ----
args:
- -config.file=/etc/loki/config/config.yaml
- -target=query-scheduler
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 59,64 ****
--- 61,72 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/querier/deployment-querier.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/querier/deployment-querier.yaml 2024-10-07 13:46:19.304235572 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/querier/deployment-querier.yaml 2024-10-07 13:46:21.506246907 +0000
***************
*** 58,63 ****
--- 58,65 ----
- -config.file=/etc/loki/config/config.yaml
- -target=querier
- -distributor.zone-awareness-enabled=true
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 68,73 ****
--- 70,81 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/index-gateway/statefulset-index-gateway.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/index-gateway/statefulset-index-gateway.yaml 2024-10-07 13:46:19.304235572 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/index-gateway/statefulset-index-gateway.yaml 2024-10-07 13:46:21.506246907 +0000
***************
*** 48,53 ****
--- 48,55 ----
args:
- -config.file=/etc/loki/config/config.yaml
- -target=index-gateway
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 58,63 ****
--- 60,71 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/ingester/statefulset-ingester-zone-c.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-c.yaml 2024-10-07 13:46:19.304235572 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-c.yaml 2024-10-07 13:46:21.506246907 +0000
***************
*** 68,73 ****
--- 68,75 ----
- -ingester.unregister-on-shutdown=false
- -ingester.tokens-file-path=/var/loki/ring-tokens
- -target=ingester
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 78,83 ****
--- 80,91 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/ingester/statefulset-ingester-zone-b.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-b.yaml 2024-10-07 13:46:19.304235572 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-b.yaml 2024-10-07 13:46:21.506246907 +0000
***************
*** 68,73 ****
--- 68,75 ----
- -ingester.unregister-on-shutdown=false
- -ingester.tokens-file-path=/var/loki/ring-tokens
- -target=ingester
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 78,83 ****
--- 80,91 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/ingester/statefulset-ingester-zone-a.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-a.yaml 2024-10-07 13:46:19.304235572 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-a.yaml 2024-10-07 13:46:21.506246907 +0000
***************
*** 68,73 ****
--- 68,75 ----
- -ingester.unregister-on-shutdown=false
- -ingester.tokens-file-path=/var/loki/ring-tokens
- -target=ingester
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 78,83 ****
--- 80,91 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/gateway/deployment-gateway-nginx.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/gateway/deployment-gateway-nginx.yaml 2024-10-07 13:46:19.304235572 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/gateway/deployment-gateway-nginx.yaml 2024-10-07 13:46:21.506246907 +0000
***************
*** 48,53 ****
--- 48,57 ----
- name: http-metrics
containerPort: 8080
protocol: TCP
+ env:
+
+ envFrom:
+
readinessProbe:
httpGet:
path: / loki/templates/distributor/deployment-distributor.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/distributor/deployment-distributor.yaml 2024-10-07 13:46:19.304235572 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/distributor/deployment-distributor.yaml 2024-10-07 13:46:21.505246902 +0000
***************
*** 51,56 ****
--- 51,58 ----
- -config.file=/etc/loki/config/config.yaml
- -target=distributor
- -distributor.zone-awareness-enabled=true
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 61,66 ****
--- 63,74 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/query-frontend/deployment-query-frontend.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/query-frontend/deployment-query-frontend.yaml 2024-10-07 13:46:19.304235572 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/query-frontend/deployment-query-frontend.yaml 2024-10-07 13:46:21.506246907 +0000
***************
*** 49,54 ****
--- 49,56 ----
args:
- -config.file=/etc/loki/config/config.yaml
- -target=query-frontend
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 59,64 ****
--- 61,72 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/ruler/statefulset-ruler.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ruler/statefulset-ruler.yaml 2024-10-07 13:46:19.305235577 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ruler/statefulset-ruler.yaml 2024-10-07 13:46:21.506246907 +0000
***************
*** 46,51 ****
--- 46,53 ----
args:
- -config.file=/etc/loki/config/config.yaml
- -target=ruler
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 56,61 ****
--- 58,69 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/compactor/statefulset-compactor.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/compactor/statefulset-compactor.yaml 2024-10-07 13:46:19.304235572 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/compactor/statefulset-compactor.yaml 2024-10-07 13:46:21.506246907 +0000
***************
*** 51,56 ****
--- 51,58 ----
args:
- -config.file=/etc/loki/config/config.yaml
- -target=compactor
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 61,66 ****
--- 63,74 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: Removed FilesNo removed files Scenario: default-values (Added: 0, Modified: 4, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/backend/statefulset-backend.yaml*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/backend/statefulset-backend.yaml 2024-10-07 13:46:19.405236092 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/backend/statefulset-backend.yaml 2024-10-07 13:46:21.611247448 +0000
***************
*** 78,83 ****
--- 78,85 ----
- -config.file=/etc/loki/config/config.yaml
- -target=backend
- -legacy-read-mode=false
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 88,93 ****
--- 90,101 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/gateway/deployment-gateway-nginx.yaml*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/gateway/deployment-gateway-nginx.yaml 2024-10-07 13:46:19.405236092 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/gateway/deployment-gateway-nginx.yaml 2024-10-07 13:46:21.611247448 +0000
***************
*** 48,53 ****
--- 48,57 ----
- name: http-metrics
containerPort: 8080
protocol: TCP
+ env:
+
+ envFrom:
+
readinessProbe:
httpGet:
path: / loki/templates/write/statefulset-write.yaml*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/write/statefulset-write.yaml 2024-10-07 13:46:19.405236092 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/write/statefulset-write.yaml 2024-10-07 13:46:21.611247448 +0000
***************
*** 53,58 ****
--- 53,60 ----
args:
- -config.file=/etc/loki/config/config.yaml
- -target=write
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 63,68 ****
--- 65,76 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/read/deployment-read.yaml*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/read/deployment-read.yaml 2024-10-07 13:46:19.405236092 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/read/deployment-read.yaml 2024-10-07 13:46:21.611247448 +0000
***************
*** 53,58 ****
--- 53,60 ----
- -target=read
- -legacy-read-mode=false
- -common.compactor-grpc-address=loki-backend.default.svc.cluster.local:9095
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 63,68 ****
--- 65,76 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: Removed FilesNo removed files Scenario: ingress-values (Added: 0, Modified: 4, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/backend/statefulset-backend.yaml*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/backend/statefulset-backend.yaml 2024-10-07 13:46:19.504236601 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/backend/statefulset-backend.yaml 2024-10-07 13:46:21.714247978 +0000
***************
*** 78,83 ****
--- 78,85 ----
- -config.file=/etc/loki/config/config.yaml
- -target=backend
- -legacy-read-mode=false
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 88,93 ****
--- 90,101 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/gateway/deployment-gateway-nginx.yaml*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/gateway/deployment-gateway-nginx.yaml 2024-10-07 13:46:19.504236601 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/gateway/deployment-gateway-nginx.yaml 2024-10-07 13:46:21.714247978 +0000
***************
*** 48,53 ****
--- 48,57 ----
- name: http-metrics
containerPort: 8080
protocol: TCP
+ env:
+
+ envFrom:
+
readinessProbe:
httpGet:
path: / loki/templates/write/statefulset-write.yaml*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/write/statefulset-write.yaml 2024-10-07 13:46:19.504236601 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/write/statefulset-write.yaml 2024-10-07 13:46:21.714247978 +0000
***************
*** 53,58 ****
--- 53,60 ----
args:
- -config.file=/etc/loki/config/config.yaml
- -target=write
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 63,68 ****
--- 65,76 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/read/deployment-read.yaml*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/read/deployment-read.yaml 2024-10-07 13:46:19.504236601 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/read/deployment-read.yaml 2024-10-07 13:46:21.714247978 +0000
***************
*** 53,58 ****
--- 53,60 ----
- -target=read
- -legacy-read-mode=false
- -common.compactor-grpc-address=loki-backend.default.svc.cluster.local:9095
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 63,68 ****
--- 65,76 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: Removed FilesNo removed files Scenario: legacy-monitoring-values (Added: 0, Modified: 4, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/backend/statefulset-backend.yaml*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/backend/statefulset-backend.yaml 2024-10-07 13:46:19.614237168 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/backend/statefulset-backend.yaml 2024-10-07 13:46:21.824248545 +0000
***************
*** 78,83 ****
--- 78,85 ----
- -config.file=/etc/loki/config/config.yaml
- -target=backend
- -legacy-read-mode=false
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 88,93 ****
--- 90,101 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/gateway/deployment-gateway-nginx.yaml*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/gateway/deployment-gateway-nginx.yaml 2024-10-07 13:46:19.614237168 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/gateway/deployment-gateway-nginx.yaml 2024-10-07 13:46:21.824248545 +0000
***************
*** 48,53 ****
--- 48,57 ----
- name: http-metrics
containerPort: 8080
protocol: TCP
+ env:
+
+ envFrom:
+
readinessProbe:
httpGet:
path: / loki/templates/write/statefulset-write.yaml*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/write/statefulset-write.yaml 2024-10-07 13:46:19.614237168 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/write/statefulset-write.yaml 2024-10-07 13:46:21.824248545 +0000
***************
*** 53,58 ****
--- 53,60 ----
args:
- -config.file=/etc/loki/config/config.yaml
- -target=write
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 63,68 ****
--- 65,76 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/read/deployment-read.yaml*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/read/deployment-read.yaml 2024-10-07 13:46:19.614237168 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/read/deployment-read.yaml 2024-10-07 13:46:21.824248545 +0000
***************
*** 53,58 ****
--- 53,60 ----
- -target=read
- -legacy-read-mode=false
- -common.compactor-grpc-address=loki-backend.default.svc.cluster.local:9095
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 63,68 ****
--- 65,76 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: Removed FilesNo removed files Scenario: simple-scalable-aws-kube-irsa-values (Added: 0, Modified: 6, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/backend/statefulset-backend.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/backend/statefulset-backend.yaml 2024-10-07 13:46:19.728237755 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/backend/statefulset-backend.yaml 2024-10-07 13:46:21.938249131 +0000
***************
*** 78,83 ****
--- 78,85 ----
- -config.file=/etc/loki/config/config.yaml
- -target=backend
- -legacy-read-mode=false
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 88,93 ****
--- 90,101 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/tokengen/job-tokengen.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/tokengen/job-tokengen.yaml 2024-10-07 13:46:19.729237760 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/tokengen/job-tokengen.yaml 2024-10-07 13:46:21.939249136 +0000
***************
*** 46,51 ****
--- 46,53 ----
- -config.file=/etc/loki/config/config.yaml
- -target=tokengen
- -tokengen.token-file=/shared/admin-token
+
+
volumeMounts:
- name: shared
mountPath: /shared
***************
*** 56,61 ****
--- 58,68 ----
- name: license
mountPath: /etc/loki/license
env:
+
+
+ envFrom:
+
+
containers:
- name: create-secret
image: docker.io/bitnami/kubectl:latest loki/templates/admin-api/deployment-admin-api.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/admin-api/deployment-admin-api.yaml 2024-10-07 13:46:19.728237755 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/admin-api/deployment-admin-api.yaml 2024-10-07 13:46:21.938249131 +0000
***************
*** 50,55 ****
--- 50,57 ----
args:
- -target=admin-api
- -config.file=/etc/loki/config/config.yaml
+
+
volumeMounts:
- name: config
mountPath: /etc/loki/config
***************
*** 81,86 ****
--- 83,90 ----
- ALL
readOnlyRootFilesystem: true
env:
+
+
nodeSelector:
{}
affinity: loki/templates/gateway/deployment-gateway-enterprise.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/gateway/deployment-gateway-enterprise.yaml 2024-10-07 13:46:19.728237755 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/gateway/deployment-gateway-enterprise.yaml 2024-10-07 13:46:21.938249131 +0000
***************
*** 53,58 ****
--- 53,60 ----
- -gateway.proxy.query-frontend.url=http://enterprise-logs-read.default.svc:3100
- -gateway.proxy.ruler.url=http://enterprise-logs-backend-headless.default.svc:3100
- -gateway.proxy.query-scheduler.url=http://enterprise-logs-backend-headless.default.svc:3100
+
+
volumeMounts:
- name: config
mountPath: /etc/loki/config
***************
*** 78,83 ****
--- 80,87 ----
- ALL
readOnlyRootFilesystem: true
env:
+
+
nodeSelector:
{}
affinity: loki/templates/write/statefulset-write.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/write/statefulset-write.yaml 2024-10-07 13:46:19.729237760 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/write/statefulset-write.yaml 2024-10-07 13:46:21.938249131 +0000
***************
*** 53,58 ****
--- 53,60 ----
args:
- -config.file=/etc/loki/config/config.yaml
- -target=write
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 63,68 ****
--- 65,76 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: loki/templates/read/deployment-read.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/read/deployment-read.yaml 2024-10-07 13:46:19.728237755 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/read/deployment-read.yaml 2024-10-07 13:46:21.938249131 +0000
***************
*** 53,58 ****
--- 53,60 ----
- -target=read
- -legacy-read-mode=false
- -common.compactor-grpc-address=enterprise-logs-backend.default.svc.cluster.local:9095
+
+
ports:
- name: http-metrics
containerPort: 3100
***************
*** 63,68 ****
--- 65,76 ----
- name: http-memberlist
containerPort: 7946
protocol: TCP
+ env:
+
+
+ envFrom:
+
+
securityContext:
allowPrivilegeEscalation: false
capabilities: Removed FilesNo removed files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces three new configurations:
extraArgs
,extraEnv
, andextraEnvFrom
to Loki's global scope within the Helm chart. These configurations are essential for reducing code duplication and improving the maintainability ofvalues.yml
files by allowing to specify additional arguments and environment variables in a centralized, reusable manner.Special notes for your reviewer:
The changes were implemented in the following way:
_helpers.tpl
extraArgs
,extraEnv
andextraEnvFrom
added tovalues.yml
under theloki
stanzaloki
loops overextraArgs
,extraEnv
andextraEnvFrom
to function callsChecklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR