Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage/bloom/v1): bind bloom page size to max bloom size #14372

Merged
merged 1 commit into from
Oct 3, 2024
Merged

chore(storage/bloom/v1): bind bloom page size to max bloom size #14372

merged 1 commit into from
Oct 3, 2024

Commits on Oct 3, 2024

  1. chore(storage/bloom/v1): bind bloom page size to max bloom size 

    Previously, the bloom page size was hard-coded to 256KB. However, 256KB
is much smaller than the normal bloom size, leading to nearly every
bloom page to be overfilled with a single, massive bloom.

Binding the bloom page size to the maximum bloom size allows bloom pages
to contain multiple smaller blooms (which are still larger than 256KB)
or one maxed out bloom.

Signed-off-by: Robert Fratto <[email protected]>
    @rfratto
    rfratto committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    4f1b053 View commit details
    Browse the repository at this point in the history