chore: Remove ring client pool from JumpHashClientPool #14367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
rfratto
approved these changes
Oct 3, 2024
pkg/bloomgateway/client_pool.go
Outdated
| // ServerList deterministically maps keys to _index_ of the server list. | ||
| // Since DNS returns records in different order each time, we sort to | ||
| // guarantee best possible match between nodes. | ||
| sort.Strings(servers) |
There was a problem hiding this comment.
Lexicographic sort isn't necessary here (and is incorrect for jumphash); jumphash needs natural sorting of servers so that z11 sorts after z2. The call to SetServers below will do a natural sort at the top of its implementation.
| if err != nil { | ||
| return nil, err | ||
| } | ||
| p.clients[addr] = client |
There was a problem hiding this comment.
Is it OK that nothing ever gets removed from p.clients?
There was a problem hiding this comment.
I think so. Worst thing is that we keep a couple of unused client objects around that are not actively used.
and replace it with a simpler implementation Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/remove-ring-client-pool
branch
from
4344ec1
to
4cc6b85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The ring client pool has functionality, such as periodic health checking of the servers and removing of stale clients, which is not needed in the JumpHashClientPool.
The removal of stale clients was problematic, because it compared the original server list (which is a list of CNAME records from the DNS lookup) with the client cache, which uses the IP of the server as key. Therefore it removed all cached clients on every check interval.
Special notes for your reviewer:
On the left side of the screenshot the index gateways use the current implementation of the client pool, then on the right side, the index gateways were updated to the new implementation. Cancelled requests are gone.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR