Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Copy Alibaba and IBM object storage configuration from common #14315

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Sep 30, 2024

Backport 59ff1ec from #14297


What this PR does / why we need it:

This PR adds code to the config_wrapper for copying object storage configuration for Alibaba Cloud / IBM Cloud from the common block to the ruler and storage configuration. This code was already present for other cloud providers, it looks as if these two were missed in the implementation.

Which issue(s) this PR fixes:

LOG-5325

Special notes for your reviewer:

  • Aside from the unit tests, I have only tested this with a Docker image based on the release-3.1.x branch.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.

@loki-gh-app loki-gh-app bot requested a review from a team as a code owner September 30, 2024 13:59
@loki-gh-app loki-gh-app bot added backport size/L type/bug Somehing is not working as expected labels Sep 30, 2024
@loki-gh-app loki-gh-app bot requested a review from periklis September 30, 2024 13:59
@chaudum chaudum changed the title chore: [release-3.2.x] fix(config): Copy Alibaba and IBM object storage configuration from common fix(config): Copy Alibaba and IBM object storage configuration from common Sep 30, 2024
@periklis periklis merged commit 32a9bc0 into release-3.2.x Oct 3, 2024
59 of 60 checks passed
@periklis periklis deleted the backport-14297-to-release-3.2.x branch October 3, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/L type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants