Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): update chart with loki version 3.2.0 #14281

Merged
merged 15 commits into from
Sep 30, 2024

Conversation

Starefossen
Copy link
Contributor

@Starefossen Starefossen commented Sep 26, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Copy link
Contributor

@DylanGuedes DylanGuedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your review! we'll need to release a new version with this, we can't leave it pointing to an already released version

production/helm/loki/Chart.yaml Outdated Show resolved Hide resolved
@Starefossen Starefossen changed the title Update loki chart with v3.2.0 feat(helm): update chart with loki version 3.2.0 Sep 26, 2024
@Starefossen
Copy link
Contributor Author

@DylanGuedes is this good to go?

@trevorwhitney
Copy link
Collaborator

trevorwhitney commented Sep 27, 2024

Is the CI failure an issue with forks not having access to GitHub Action secrets? app-id is provided from a secret, and it looks like it's passing from branches but not forks?

@DylanGuedes
Copy link
Contributor

@DylanGuedes is this good to go?

sorry, it is/was, but because we recently changed how our CI does the package publishing, we'll need you to rebase one more time and to also update the version from 6.16.0 to 6.17.0 (we had to do a release in between and we preferred it to be before using loki 3.2.0 for stability reasons)

@DylanGuedes
Copy link
Contributor

hey I believe this lint step keeps breaking because rebasing isn't updating your branch code to receive the changes since they're for a different folder.
super annoying but do you mind copying .github/workflows/helm-ci.yaml from main branch to your branch and pushing a commit with it?

@Starefossen
Copy link
Contributor Author

Updated the workflow, but still failing. My guess is that this relates to access to secrets from forks.

@trevorwhitney trevorwhitney merged commit 11b92ee into grafana:main Sep 30, 2024
63 checks passed
jeschkies pushed a commit to jeschkies/loki that referenced this pull request Oct 1, 2024
@Starefossen
Copy link
Contributor Author

@trevorwhitney any reason why I can not find this version up on Artifacthub? https://artifacthub.io/packages/helm/grafana/loki

mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@trevorwhitney
Copy link
Collaborator

@Starefossen we had an issue with our release automation, you should be able to find version 6.18 of the chart now, and it has Loki 3.2

@Starefossen
Copy link
Contributor Author

Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants