chore: Allow setting annotations for memberlist and query-scheduler-discovery services #14211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
area/helm
type/docs
tabboud
commented
Sep 20, 2024
| {{- with .Values.loki.serviceAnnotations }} | ||
| {{- toYaml . | nindent 4}} | ||
| {{- end }} | ||
| {{- with .Values.backend.service.annotations }} |
There was a problem hiding this comment.
The query-scheduler-discovery service is not technically the backend service, but given it's deployed along with it and currently uses the backendSelectorLabels, this seems appropriate to add these annotations as well.
There was a problem hiding this comment.
yep that looks correct.
slim-bean
changed the title
DylanGuedes
reviewed
Sep 25, 2024
| {{- with .Values.loki.serviceAnnotations }} | ||
| {{- toYaml . | nindent 4}} | ||
| {{- end }} | ||
| {{- with .Values.backend.service.annotations }} |
There was a problem hiding this comment.
yep that looks correct.
|
@DylanGuedes Thanks for the review. I updated the relevant files for the new |
DylanGuedes
approved these changes
Sep 26, 2024
jeschkies
pushed a commit
to jeschkies/loki
that referenced
this pull request
Oct 1, 2024
…iscovery services (grafana#14211) **What this PR does / why we need it**: Both the memberlist and query-scheduler-discovery services do not provide a way to add annotations.
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
…iscovery services (grafana#14211) **What this PR does / why we need it**: Both the memberlist and query-scheduler-discovery services do not provide a way to add annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Both the memberlist and query-scheduler-discovery services do not provide a way to add annotations.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR