feat(helm): ✨ add additional service annotations for components in distributed mode #14131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chaudum
approved these changes
Sep 13, 2024
github-actions
bot
added
the
type/docs
You're welcome, thanks for the quick review. I updated the docs, hopefully that fixes the remaining CI issues. |
|
@dannylongeuay The Helm docs lint check still fails :/ |
|
@chaudum fixed the readme versions I missed |
jeschkies
pushed a commit
to jeschkies/loki
that referenced
this pull request
Oct 1, 2024
…stributed mode (grafana#14131) Co-authored-by: Christian Haudum <[email protected]> Co-authored-by: Trevor Whitney <[email protected]>
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
…stributed mode (grafana#14131) Co-authored-by: Christian Haudum <[email protected]> Co-authored-by: Trevor Whitney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Support additional service annotations for components in distributed mode.
Which issue(s) this PR fixes:
Fixes #8627
Special notes for your reviewer:
A previous PR #10214 added support for the simple scalable components, this PR adds support for the distributed mode components.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR