chore: Rename PendingItem to PendingSegment and clean up flush.go #13554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
force-pushed
the
grobinson/wal-cleanup
branch
from
f0d44bb
to
c955df1
Compare
| }() | ||
|
|
||
| i.metrics.flushesTotal.Add(1) |
There was a problem hiding this comment.
We were not incrementing this metric if w.WriteTo failed. This is now fixed.
| buf := i.flushBuffers[j] | ||
| defer buf.Reset() | ||
| if _, err := w.WriteTo(buf); err != nil { | ||
| i.metrics.flushFailuresTotal.Inc() |
There was a problem hiding this comment.
Same here.
| // PendingItem contains a result and the segment to be flushed. | ||
| type PendingItem struct { | ||
| // PendingSegment contains a result and the segment to be flushed. | ||
| type PendingSegment struct { |
There was a problem hiding this comment.
Seemed a better name to me.
| func (b *SegmentWriter) Observe() { | ||
| // ReportMetrics for the writer. If called before WriteTo then the output size | ||
| // histogram will observe 0. | ||
| func (b *SegmentWriter) ReportMetrics() { |
There was a problem hiding this comment.
Also seemed a better name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Rename
PendingItemtoPendingSegmentand clean upflush.go.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR