chore: Use pool of bytes.Buffer instead of io.Pipe #13543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
approved these changes
Jul 16, 2024
pkg/ingester-rf1/flush.go
Outdated
| }() | ||
|
|
||
| buf := i.flushBuffers.Get().(*bytes.Buffer) |
There was a problem hiding this comment.
Nit: if we can avoid a pool by scoping this to the segment writer or the flush worker it's better
There was a problem hiding this comment.
We can do concurrent flushes (in the case where write volume is more than 8MB/sec) so I think we want a pool?
There was a problem hiding this comment.
Oh I misunderstood. Let me do that :)
grobinson-grafana
force-pushed
the
grobinson/use-buffer-instead-of-pipe
branch
from
9a4c624
to
f7bb072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR uses a pool of
bytes.Bufferinstead ofio.Pipe.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR