-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add logging for empty blooms #13537
Conversation
6bfe8a5
to
59992e5
Compare
// Here we log an error if we find an empty bloom. | ||
if bloom.Count() == 0 { | ||
level.Warn(bt.logger).Log( | ||
"msg", "Found existing empty bloom", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
messages should start with lower case letters
"msg", "Found existing empty bloom", | |
"msg", "found existing empty bloom", |
Hello @salvacorts!
Please, if the current pull request addresses a bug fix, label it with the |
(cherry picked from commit b44517a)
What this PR does / why we need it:
Check empty blooms during creation and log them.
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR