Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add logging for empty blooms #13537

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:
Check empty blooms during creation and log them.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts changed the title debug: Add logging for empty blooms test: Add logging for empty blooms Jul 16, 2024
@salvacorts salvacorts force-pushed the salvacorts/print-empty-bloom-creation branch from 6bfe8a5 to 59992e5 Compare July 16, 2024 10:31
@salvacorts salvacorts marked this pull request as ready for review July 16, 2024 10:35
@salvacorts salvacorts requested a review from a team as a code owner July 16, 2024 10:35
// Here we log an error if we find an empty bloom.
if bloom.Count() == 0 {
level.Warn(bt.logger).Log(
"msg", "Found existing empty bloom",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

messages should start with lower case letters

Suggested change
"msg", "Found existing empty bloom",
"msg", "found existing empty bloom",

@salvacorts salvacorts merged commit b44517a into main Jul 16, 2024
60 checks passed
@salvacorts salvacorts deleted the salvacorts/print-empty-bloom-creation branch July 16, 2024 10:55
@grafanabot
Copy link
Collaborator

Hello @salvacorts!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@salvacorts salvacorts added type/bug Somehing is not working as expected backport k211 and removed backport k211 labels Jul 16, 2024
grafanabot pushed a commit that referenced this pull request Jul 16, 2024
@salvacorts salvacorts mentioned this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k211 size/M type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants