chore: Clean up old streams periodically in RF-1 ingester #13511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstyan
reviewed
Jul 13, 2024
| for { | ||
| select { | ||
| case <-flushTicker.C: | ||
| i.doFlushTick() | ||
| case <-streamRetentionTicker.C: |
There was a problem hiding this comment.
do you want to move this ticker check to a separate go routine loop so that doFlushTick would never be blocked by the stream cleanup? I imagine flushing data is more important than clearing memory at least in the short term
There was a problem hiding this comment.
Yeah, thats a good point. I'll create a separate goroutine
There was a problem hiding this comment.
+1 because I want to remove this select :)
github-actions
bot
added
the
type/docs
grobinson-grafana
approved these changes
Jul 16, 2024
benclive
force-pushed
the
benclive/prune-old-streams-rf1
branch
from
ed773c9
to
667ff4c
Compare
benclive
force-pushed
the
benclive/prune-old-streams-rf1
branch
from
667ff4c
to
34a10fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes https://github.com/grafana/loki-private/issues/1034