-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operator): Add support for Loki OTLP limits config #13446
Merged
Merged
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
efc4f0b
Add API support for OTLPConfig
periklis cad28a7
Add OTLP config rendering
periklis 6a7bef4
Add api docs for OTLP attributes
periklis 325c9e3
Rename API fields from OpenTelemetry to OTLP
periklis e250fba
Address code review suggestions
periklis ae5b700
Merge remote-tracking branch 'upstream/main' into lokistack-otlp-config
periklis ccebda5
Address code review suggestions
periklis 360a829
Apply code review suggestions
periklis 9f8dcdf
Regenerate api docs
periklis 9914bdb
Validate OTLPSpec
periklis 3eb9f45
Merge remote-tracking branch 'upstream/main' into lokistack-otlp-config
periklis ba25f93
Apply code review suggestions
periklis d6b4f71
Regenerate api docs
periklis f117905
Merge remote-tracking branch 'upstream/main' into lokistack-otlp-config
periklis d3c4209
Apply suggestions from code review
periklis cd95a95
Use camel-case for OTLPAttributeAction enum values
periklis 2d245e8
Regenerate api docs
periklis 2825a14
Merge remote-tracking branch 'upstream/main' into lokistack-otlp-config
periklis fe70fbe
Simplify OTLPAttributeAction helper
periklis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed yesterday, but forgot to add the comment... 🙄
Do we want to follow any existing convention with the enum values? Official Kubernetes is
CamelCase
, our convention in Loki Operator so far seems to becamelCase
and notsnake_case
like in the Loki configuration.(needs to also update the validations if changed)