build: Loki build and Docker updates #13325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…distroless loki image
trevorwhitney
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
LGTM! Note we'll eventually want to expose the additional build args to the release pipeline.
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jul 22, 2024
Following a trend by at other database teams: * grafana/loki#13325 * grafana/mimir#8204
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jul 22, 2024
Following a trend by at other database teams: * grafana/loki#13325 * grafana/mimir#8204
simonswine
added a commit
to grafana/pyroscope
that referenced
this pull request
Jul 23, 2024
* chore: Replace alpine with distroless Following a trend by at other database teams: * grafana/loki#13325 * grafana/mimir#8204 * Also build debug image for main
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR does the following:
GO_VERSIONargument into the Dockerfiles from the Makefile, allowing the version to be updated in a single place, and all images will be built with that Go version.gcr.io/distroless/base:debugas a base, instead ofAlpine.Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR