-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allows to configure client_max_body_size #12924
Open
satyamsundaram
wants to merge
1
commit into
grafana:main
Choose a base branch
from
satyamsundaram:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/helm
type/docs
Issues related to technical documentation; the Docs Squad uses this label across many repositories
labels
May 9, 2024
satyamsundaram
force-pushed
the
main
branch
2 times, most recently
from
May 10, 2024 05:19
0d14b21
to
8b9b7d1
Compare
trevorwhitney
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, need to bump the version but otherwise let's get this merged!
I've bumped the version. Let me know if there are any other changes required. |
satyamsundaram
changed the title
feat(Helm): Allows to configure client_max_body_size
feat: Allows to configure client_max_body_size
May 24, 2024
Are there any updates on the merge for this one? |
satyamsundaram
changed the title
feat: Allows to configure client_max_body_size
feat: Allows to configure client_max_body_size
Sep 28, 2024
satyamsundaram
force-pushed
the
main
branch
from
September 28, 2024 07:30
a35a6f9
to
766072d
Compare
I've fixed all merge conflicts. It can be merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adjusting
client_max_body_size
in Nginx allows us to fix this nginx error:client intended to send too large body
.Which issue(s) this PR fixes:
Fixes #8736, #10521
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR