fix(helm) Add capability to ignore the gateway service by the serviceMonitor #12909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR sets per default the label
prometheus.io/scrape=false
to the gateway service.This causes the gateway service not to be treated as a Prometheus scrape target and fixes alerts that the target is down and can't be scraped. This is useful because the nginx does not provide any metrics in the default configuration.
Users could either add the label manually or we set it per default. With this PR I would pitch the 2nd option so that users don't have to investigate the alerts caused by a default loki deployment via helm.
Which issue(s) this PR fixes:
Could not find any related issue and experienced the issue by myself when switching from the loki-distributed to the loki chart.
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR