docs: Update docker installation topic #12770
Conversation
JStickler
added
type/docs
|
This PR must be merged before a backport PR will be created. |
1 similar comment
|
This PR must be merged before a backport PR will be created. |
JStickler
changed the title
JStickler
changed the title
|
|
||
| ## Prerequisites | ||
|
|
||
| - [Docker](https://docs.docker.com/install) | ||
| - [Docker Compose](https://docs.docker.com/compose/install) (optional, only needed for the Docker Compose install method) | ||
|
|
||
| ## Install with Docker | ||
| ## Install with Docker on Linux |
There was a problem hiding this comment.
What's specific about Linux here? Will these instructions not work on Mac/BSD/etc?
There was a problem hiding this comment.
Good question, I was trying to differentiate between this and the Windows installation. Any suggestions for a better heading?
There was a problem hiding this comment.
Actually, that was already the heading....
There was a problem hiding this comment.
The heading was previously Install with Docker not Install with Docker on Linux unless I'm missing something?
There was a problem hiding this comment.
Previous heading arrangement ^
There was a problem hiding this comment.
Oh yeah, the bold bit after. Makes sense to make that part of the heading instead.
Probably worth visiting if the instructions are suitable for other similar platforms later
(cherry picked from commit afbeedc)
Which issue(s) this PR fixes:
Fixes #12155
Updated the docker installation topic before I realized that the issue was for docker install for Promtail. So two updates for the price of one!
Splits out the commands into separate steps for downloading and running the files. Adds some validation steps (for Linux).