ci: add a github action for linting jsonnet #12527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Callum Styan <[email protected]>
cstyan
force-pushed
the
callum-additional-drone-removal
branch
from
9c65732
to
3549e37
Compare
Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Callum Styan <[email protected]>
trevorwhitney
requested changes
Apr 12, 2024
| go install github.com/monitoring-mixins/mixtool/cmd/mixtool@16dc166166d91e93475b86b9355a4faed2400c18 | ||
| go install github.com/jsonnet-bundler/jsonnet-bundler/cmd/[email protected] | ||
| - name: run linting | ||
| run: make BUILD_IN_CONTAINER=false lint-jsonnet |
There was a problem hiding this comment.
we're already linting jsonnet in the check action that runs for every PR, so we should remove this check again here
There was a problem hiding this comment.
IMO we should be moving as much as possible out of the giant check action, I can remove the linting from that action in this PR?
trevorwhitney
approved these changes
Apr 16, 2024
5 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drone is still running our jsonnet linting job, we can migrate that to a github action
NOTE: for some reason the drone job doesn't fail, but locally or via the new github action here the linting will fail. I may update our jsonnet files to match the linting in this PR.