Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove experimental flags from features and configs which are no longer so. #12481

Merged
merged 1 commit into from
Apr 5, 2024
Merged

chore: remove experimental flags from features and configs which are no longer so. #12481

merged 1 commit into from
Apr 5, 2024

Conversation

slim-bean
Copy link
Collaborator

What this PR does / why we need it:

I revisited things marked as experimental and updates several things which no longer need be considered experimental for Loki 3.0

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@slim-bean slim-bean requested a review from a team as a code owner April 4, 2024 23:28
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 4, 2024
rfratto
rfratto previously approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Perfect To Me

@rfratto rfratto dismissed their stale review April 4, 2024 23:40

sorry, I didn't see the CI failed :( I was too hasty in thinking this PR was perfect

rfratto
rfratto approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's definitely perfect to me

trevorwhitney
trevorwhitney approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@slim-bean slim-bean merged commit 705379c into main Apr 5, 2024
12 checks passed
@slim-bean slim-bean deleted the unexperimental-deletes branch April 5, 2024 12:55
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@slim-bean @rhnasc
chore: remove experimental flags from features and configs which are …
49a404a 
…no longer so. (grafana#12481)

Signed-off-by: Edward Welch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevorwhitney trevorwhitney trevorwhitney approved these changes

@rfratto rfratto rfratto approved these changes

Assignees
No one assigned
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slim-bean @trevorwhitney @rfratto