-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add some docs around a schema value for new installs #12424
Conversation
Signed-off-by: Edward Welch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm few nits
object_store: gcs | ||
schema: v13 | ||
store: tsdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy/ paste error?
Lines 68 - 70 are the same as lines 75 - 77, with the exception of the schema value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, I see what you're doing here with from
and the dates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually all this was is a change to indentation to remove the tab chars and use spaces instead which I think is better for copy pasting yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] Other than two random ticks at line 18, LGTM.
Co-authored-by: Dylan Guedes <[email protected]>
Co-authored-by: Dylan Guedes <[email protected]>
Co-authored-by: Dylan Guedes <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]> Co-authored-by: Dylan Guedes <[email protected]>
Signed-off-by: Edward Welch <[email protected]> Co-authored-by: Dylan Guedes <[email protected]>
…2424) Signed-off-by: Edward Welch <[email protected]> Co-authored-by: Dylan Guedes <[email protected]>
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR