feat: prepare 3.0.0 release candidate again #12379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release-As: 3.0.0-rc.1
.release-please-manifest.json
Outdated
| @@ -1,3 +1,3 @@ | |||
| { | |||
| ".": "2.9.6" | |||
| ".": "2.9.6-rc.1" | |||
There was a problem hiding this comment.
Should this still be 2.9.6?
There was a problem hiding this comment.
yes it should be 2.9.6, not sure about the -rc.1 yet though. the Release-As: 3.0.0-rc.1 comment in the commit body was not being detected as it is supposed to be. This is probably a bug in release-please, but given time constraints I'm opting to run a new release pipeline with a versioning strategy of always-bump-major.
slim-bean
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release-As: 3.0.0-rc.1
What this PR does / why we need it:
The existing minor release is not picking up our custom version via the
Release-Ascommit. Before debuggingrelease-pleaseto figure out way, I'm hoping this will force the correct version.