Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the capability to configure Loki without needing to rebuild the… #11759

Closed
wants to merge 0 commits into from

Conversation

Gordejj
Copy link

@Gordejj Gordejj commented Jan 24, 2024

… operator

What this PR does / why we need it:
I added the capability to append template for Loki config without needing to rebuild the operator. In our case, we are developing a private cloud and want to provide logging as a service. This means that multiple user spaces will have clusters deployed with the loki-operator.
Therefore, we cannot rebuild the loki-operator for each such project individually. It's easier for us to create a template with the Loki configuration as an external dependency, which can be provided to the operator at runtime to modify the config-map and manually restart the components.
I understand the best way is to develop resources, but it seems that a quick workaround would also be useful.

Special notes for your reviewer:
Automatic restart for applying configuration changes is not provided, only a guarantee of modifying the YAML file is assured.
Updated the old test cases but did not add new ones.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • [] Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Gordejj
❌ dmitry.gordeev


dmitry.gordeev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants