-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Labeler: label PRs which update **/README.md as type/docs #11754
base: main
Are you sure you want to change the base?
Conversation
@jswank I wasn't sure after our exchange of comments on your issue, did you want to move ahead on this PR? I don't approve PRs outside of |
@JStickler My understanding is that you and docs team are the primary beneficiaries of the PR. If your workflow is improved by labelling PRs updating README.md for review by your team, then moving ahead makes sense. If that is not beneficial to you, then the issue and this PR can be closed. |
@trevorwhitney @jeschkies Tagging you because you were the last ones to update these files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't know a ton about this action, but based on a quick reading of https://github.com/actions/labeler this lgtm!
What this PR does / why we need it:
Ensure that PRs which modify **/README.md are labeled appropriately with the type/docs label. See #11753 for details.
Which issue(s) this PR fixes:
Fixes #11753
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR