Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bloom checksum work #11752

Closed
wants to merge 6 commits into from
Closed

Bloom checksum work #11752

wants to merge 6 commits into from

Conversation

paul1r
Copy link
Collaborator

@paul1r paul1r commented Jan 23, 2024

What this PR does / why we need it:

Previously, MergeBuilder.Build() used a checksum of the bloom page headers. This PR does multiple things in relation to checksums, including:

  • Augmenting the bloom page header to have a checksum of the data of the bloom page (in order to capture the actual content of the blooms). As a result, a bloom page with a single bloom should now differ from another bloom page with a single bloom, unless the contents of the two blooms are exactly equal.
  • Add checksum calculations for the block options
  • Return the checksums when Close()ing the series data
  • Augmenting the checksum calculations to include the checksum of the bloom pages, the series pages, and the block options

This will render existing bloom data invalid.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@paul1r paul1r requested a review from a team as a code owner January 23, 2024 17:02
@paul1r paul1r closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant