-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ruler): enables ruler store that uses clients from thanos-io/objstore pkg #11713
Draft
ashwanthgoli
wants to merge
12
commits into
main
Choose a base branch
from
ashwanth/ruler-thanos-storage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
Issues related to technical documentation; the Docs Squad uses this label across many repositories
label
Jan 19, 2024
ashwanthgoli
force-pushed
the
ashwanth/ruler-thanos-storage
branch
from
January 19, 2024 09:42
fd9a102
to
0a383b8
Compare
ashwanthgoli
changed the title
feat(ruler): add support for using thanos objstore
feat(ruler): adds a new ruler store that uses clients from thanos-io/objstore pkg
Jan 19, 2024
ashwanthgoli
changed the title
feat(ruler): adds a new ruler store that uses clients from thanos-io/objstore pkg
feat(ruler): enables ruler store that uses clients from thanos-io/objstore pkg
Jan 19, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Rulers already have the necessary code to use the objstore clients created from
thanos-io/objstore
pkg.This pr exposes the
ruler_storage
block which enables users to configure these clients. This is similar to how mimir ruler storage is configured and helps keep the configuration more consistent across the projects.storage
block in theruler
configuration is already marked as deprecatedWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
support for other providers (bos, cos, alibabacloud) and the tooling to help with configuration changes will be added in follow-up prs
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR