-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not reflect label names in request metrics' "route" label #11551
Do not reflect label names in request metrics' "route" label #11551
Conversation
Fixes grafana#11549 Signed-off-by: Danny Kopping <[email protected]>
Trivy scan found the following vulnerabilities:
|
Signed-off-by: Danny Kopping <[email protected]>
Hello @dannykopping!
Please, if the current pull request addresses a bug fix, label it with the |
Hello @dannykopping!
Please, if the current pull request addresses a bug fix, label it with the |
…#11551) **Which issue(s) this PR fixes**: Fixes grafana#11549
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-11551-to-release-2.8.x origin/release-2.8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 18ea38883f62bb8b28150a1f42ccd2d74fb03389 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-11551-to-release-2.8.x
# Create the PR body template
PR_BODY=$(gh pr view 11551 --json body --template 'Backport 18ea38883f62bb8b28150a1f42ccd2d74fb03389 from #11551{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[release-2.8.x] Do not reflect label names in request metrics' \"route\" label" --body-file - --label "size/XS" --label "type/bug" --label "backport" --base release-2.8.x --milestone release-2.8.x --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-11551-to-release-2.8.x
# Create a pull request where the `base` branch is `release-2.8.x` and the `compare`/`head` branch is `backport-11551-to-release-2.8.x`.
# Remove the local backport branch
git switch main
git branch -D backport-11551-to-release-2.8.x |
…#11551) **Which issue(s) this PR fixes**: Fixes grafana#11549 (cherry picked from commit 18ea388)
…#11551) **Which issue(s) this PR fixes**: Fixes grafana#11549 (cherry picked from commit 18ea388)
…#11551) **Which issue(s) this PR fixes**: Fixes grafana#11549 (cherry picked from commit 18ea388)
…#11551) **Which issue(s) this PR fixes**: Fixes grafana#11549
Which issue(s) this PR fixes:
Fixes #11549
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR