-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Missing Redis Ports by Defaulting to Standard Redis Port in Loki #11414
Open
nstankov-bg
wants to merge
7
commits into
grafana:main
Choose a base branch
from
nstankov-bg:bug/redis-no-port-defaults
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7801776
"Enhanced endpoint derivation logic to handle cases without specified…
nstankov-bg 31e36b9
Merge branch 'main' into bug/redis-no-port-defaults
nstankov-bg b3c2442
Merge branch 'main' into bug/redis-no-port-defaults
nstankov-bg 7af31f1
Merge branch 'main' into bug/redis-no-port-defaults
nstankov-bg ea996bc
Merge branch 'main' into bug/redis-no-port-defaults
nstankov-bg c2d9445
Merge branch 'main' into bug/redis-no-port-defaults
nstankov-bg dd236a4
Merge branch 'main' into bug/redis-no-port-defaults
nstankov-bg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels like something we should do via a
validateConfig
function before passing the config to the client creation@dannykopping I think you worked on the caching code the most recently, any thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you would like me to approach this differently. I would be happy to contribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following up on this @dannykopping and @cstyan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have a new function that's called before
deriveEndpoints
inNewRedisClient
that logs a warning for every endpoint that doesn't have a port set clarifying that the default port will be used. Alternatively, this new function could be called beforeNewRedisClient
incache.go
New
.