Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonnet: Introduce backend target for Simple Scalable deployment mode #11342

Closed
wants to merge 9 commits into from

Conversation

szuro
Copy link

@szuro szuro commented Nov 30, 2023

What this PR does / why we need it:

This PR adds the backend target for Simple Scalable deployment mode.
It also changes the read target deployment mode from StatefulSet to Deployment as per docs:

-target=read - The read target is stateless and can be run as a Kubernetes Deployment that can be scaled automatically. It contains the following components: – Query front end – Queriers

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@szuro szuro requested a review from a team as a code owner November 30, 2023 12:44
@CLAassistant
Copy link

CLAassistant commented Nov 30, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 30, 2023
Copy link
Contributor

Trivy scan found the following vulnerabilities:

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Docs team] Fixed a couple of typos in the documentation.

docs/sources/setup/upgrade/_index.md Outdated Show resolved Hide resolved
docs/sources/setup/upgrade/_index.md Outdated Show resolved Hide resolved
@szuro
Copy link
Author

szuro commented Dec 5, 2023

[Docs team] Fixed a couple of typos in the documentation.

Thanks for noticing!

@szuro szuro requested a review from JStickler January 23, 2024 14:16
@szuro
Copy link
Author

szuro commented Sep 2, 2024

Resolved by #13976

@szuro szuro closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants