Remove querier wait time metric. #11233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,7 +65,9 @@ func (pm *processorManager) concurrency(n int) { | |||
| n = 0 | |||
| } | |||
|
|
|||
| workerId := 0 | |||
There was a problem hiding this comment.
i am guessing the workerId does not matter much here. but there is a chance here of re-using workerIds if the concurrency value changes.
There was a problem hiding this comment.
Good question. I wonder what happens then. Are we restarting the querier?
There was a problem hiding this comment.
when more schedulers get added? which means each worker gets a smaller concurrency value.
not something that is often done in practice, so it should be alright I think
Co-authored-by: Danny Kopping <[email protected]>
…karsten/move-queuing-time
|
Trivy scan found the following vulnerabilities:
|
cstyan
reviewed
Dec 4, 2023
| @@ -58,7 +58,7 @@ func (fp *frontendProcessor) notifyShutdown(ctx context.Context, conn *grpc.Clie | |||
| } | |||
|
|
|||
| // runOne loops, trying to establish a stream to the frontend to begin request processing. | |||
| func (fp *frontendProcessor) processQueriesOnSingleStream(ctx context.Context, conn *grpc.ClientConn, address string) { | |||
| func (fp *frontendProcessor) processQueriesOnSingleStream(ctx context.Context, conn *grpc.ClientConn, address, _ string) { | |||
There was a problem hiding this comment.
is the _ param intentional here?
There was a problem hiding this comment.
Yes, processQueriesOnSingleStream implements the processor interface and we don't use the worker ID in the case of the frontend processor.
| @@ -39,7 +39,7 @@ func TestRecvFailDoesntCancelProcess(t *testing.T) { | |||
| running.Store(true) | |||
| defer running.Store(false) | |||
|
|
|||
| mgr.processQueriesOnSingleStream(ctx, cc, "test:12345") | |||
| mgr.processQueriesOnSingleStream(ctx, cc, "test:12345", "1") | |||
There was a problem hiding this comment.
You are right. Since it's ignored we don't need it here.
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
**What this PR does / why we need it**: We would like to know how long a querier worker is idle to understand if workstealing would have an impact. The original metric was too noisy and its cardinality was too high. Instead, we are going to log the wait time. **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](grafana@0d4416a) --------- Co-authored-by: Danny Kopping <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We would like to know how long a querier worker is idle to understand if workstealing would have an impact. The original metric was too noisy and its cardinality was too high. Instead, we are going to log the wait time.
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR