Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/loki): embed LogCLI into Loki image #11146

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hainenber
Copy link
Contributor

What this PR does / why we need it:
Embed LogCLI into Loki's Docker image for better DX.

Which issue(s) this PR fixes:
Fixes #11142

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@hainenber hainenber requested a review from a team as a code owner November 6, 2023 15:23
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 6, 2023
@cstyan
Copy link
Contributor

cstyan commented Nov 6, 2023

I'm not sure this is something we'd want in the default image.

@trajano
Copy link

trajano commented Nov 6, 2023

Thx for looking into it quickly. Hope to see a build soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add lokicli to the docker image
3 participants