Build loki-build-image for multiple architectures. #11130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
kavirajk
reviewed
Nov 6, 2023
There was a problem hiding this comment.
Overall looks good 👍 left few comments.
Also I think we need make sure this change reflects on two of our docs pages.
- Building loki-build-image
- Patching Go version on loki-build-image (when we need to patch release)
| COPY --from=helm /usr/bin/helm /usr/bin/helm | ||
| COPY --from=helm /go/bin/helm-docs /usr/bin/helm-docs | ||
| COPY --from=helm /usr/local/bin/helm /usr/bin/helm | ||
| COPY --from=helm /usr/local/bin/helm-docs /usr/bin/helm-docs |
There was a problem hiding this comment.
why we need this change? curious how was it working before?
There was a problem hiding this comment.
See line 13 and 16. I had to download the proper release. I guess for helm-docs it could have still worked with go modules.
| PUSH_OCI=img push | ||
| TAG_OCI=img tag | ||
| OCI_PLATFORMS=--platform=linux/amd64,linux/arm64 | ||
| BUILD_OCI=docker buildx build $(OCI_PLATFORMS) --build-arg $(BUILD_IMAGE) |
There was a problem hiding this comment.
Looks like we are just building and not pushing now?
There was a problem hiding this comment.
Look at line 106. PUSH_OCI is still defined. This is just for defining variables. There's no make target here.
Luckily there's no change. The CI will still publish the build image. However, I've just looked at the Go version patch docs. They are wrong. |
github-actions
bot
added
the
type/docs
ashwanthgoli
pushed a commit
that referenced
this pull request
Nov 6, 2023
**What this PR does / why we need it**: The current `loki-build-image` is for `amd64` only. However, many are developing Loki on Apple Silicon. That's why we should publish build images for `arm64` as well. **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](0d4416a)
trevorwhitney
added a commit
that referenced
this pull request
Nov 8, 2023
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
**What this PR does / why we need it**: The current `loki-build-image` is for `amd64` only. However, many are developing Loki on Apple Silicon. That's why we should publish build images for `arm64` as well. **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](grafana@0d4416a)
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
**What this PR does / why we need it**: The changes in grafana#11130 broke `make build-image` and `make build-image-push`. This defaults the target arch added in grafana#11130 so those make targets still work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The current
loki-build-imageis foramd64only. However, many are developing Loki on Apple Silicon. That's why we should publish build images forarm64as well.Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR