-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Add automatic stream sharding support #11091
operator: Add automatic stream sharding support #11091
Conversation
operator/internal/manifests/internal/config/loki-runtime-config.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Jacob <[email protected]>
Trivy scan found the following vulnerabilities:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review in code only as I'm on the move and not testing on a cluster.
operator/internal/manifests/internal/config/loki-runtime-config.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work nicely 👍
Left two more comments.
Co-authored-by: Robert Jacob <[email protected]>
What this PR does / why we need it:
The following PR adds automatic stream sharding support for all
LokiStack
deployment sizes in the Loki Operator. In particular it replaces present defaults likeper_stream_rate_limit: 3MB
with adesiredRate: 3MB
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR