Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tools/lambda-promtail): not evaluate empty string for drop_labels #11074

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix(tools/lambda-promtail): not evaluate empty string for drop_labels #11074

merged 2 commits into from
Nov 6, 2023

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Oct 28, 2023 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #11005

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory.

@hainenber hainenber requested a review from a team as a code owner October 28, 2023 14:51
@hainenber hainenber changed the title feat(tools/lambda-promtail): not evaluate empty string for drop_labels fix(tools/lambda-promtail): not evaluate empty string for drop_labels Oct 28, 2023
@spedersen-emailage
Copy link

Thanks @hainenber !

chaudum
chaudum approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaudum chaudum force-pushed the fix-panicked-lambda-promtail-due-to-empty-dropabel-string branch from 52891e8 to 75c6e10 Compare November 6, 2023 10:14
@chaudum chaudum merged commit 94169a0 into grafana:main Nov 6, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Jan 26, 2024
Closed
@grafanabot grafanabot mentioned this pull request Feb 13, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Feb 28, 2024
Closed
This was referenced Mar 25, 2024
Closed
Closed
Closed
Closed
This was referenced Apr 1, 2024
Closed
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Apr 8, 2024
Merged
@grafanabot grafanabot mentioned this pull request Apr 8, 2024
Merged
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@hainenber @rhnasc
fix(tools/lambda-promtail): Do not evaluate empty string for drop_lab…
de3716c 
…els (grafana#11074)

Fixes grafana#11005 

Signed-off-by: hainenber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum chaudum approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lambda/promtail: lambda/promtail fails to send logs with "panic: invalid label name"
3 participants
@hainenber @spedersen-emailage @chaudum