s3: Added option to skip tls verify

[Sheikh-Abubaker]

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #10030

Special notes for your reviewer:

Checklist

• Reviewed the CONTRIBUTING.md guide (required)
• Documentation added
• Tests updated
• CHANGELOG.md updated
  • If the change is worth mentioning in the release notes, add add-to-release-notes label
• Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
• For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
• If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory.

[david-nano]

I don't see any change on the templates of the helm chart. How do the implementation will be applied?

[Sheikh-Abubaker]

I don't see any change on the templates of the helm chart. How do the implementation will be applied?

I went through the official documentation : https://grafana.com/docs/loki/latest/configure/#s3_storage_config

Here there is a parameter defined insecure_skip_verify which states that enabling the mentioned parameter will
help to skip verification of certificate.

[Sheikh-Abubaker]

Hi @david-nano, is this PR up to the mark for resolving the respective issue ?

[j4rj4r]

Hello,

This variable must be added by the user only if he needs it. Why put it by default in values.yaml and make it even more complex?

The option already exists, the user just needs to modify the values.yaml and run helm install. No need for a PR.

[david-nano]

respective

Yes it is

[Sheikh-Abubaker]

@JStickler can you please request review for this PR it's been a while since I've opened this PR, if there are any changes needed I'd be glad to contribute.

[Sheikh-Abubaker]

@MichelHollands seems like folks are in need of this feature please see comments of issue #10030

[MichelHollands]

@Sheikh-Abubaker This is not needed. You should specify the insecure_skip_verify setting in the http_config block in the values.yaml you pass when deploying the chart. The change you are making here is changing it in the default values. This will make everyone's installation less secure.