Skip to content

Commit

Permalink
chore: Remove size and duration logs now we have metrics (#13547)
Browse files Browse the repository at this point in the history
  • Loading branch information
grobinson-grafana authored Jul 17, 2024
1 parent 47d0578 commit e1f9eb5
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions pkg/ingester-rf1/flush.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"net/http"
"time"

"github.com/dustin/go-humanize"
"github.com/go-kit/log"
"github.com/go-kit/log/level"
"github.com/grafana/dskit/backoff"
Expand Down Expand Up @@ -84,18 +83,9 @@ func (i *Ingester) flushWorker(j int) {
continue
}

start := time.Now()

// We'll use this to log the size of the segment that was flushed.
n := it.Writer.InputSize()
humanized := humanize.Bytes(uint64(n))

err = i.flushItem(l, j, it)
d := time.Since(start)
if err != nil {
level.Error(l).Log("msg", "failed to flush", "size", humanized, "duration", d, "err", err)
} else {
level.Debug(l).Log("msg", "flushed", "size", humanized, "duration", d)
level.Error(l).Log("msg", "failed to flush", "err", err)
}

it.Result.SetDone(err)
Expand Down

0 comments on commit e1f9eb5

Please sign in to comment.