Skip to content

Commit

Permalink
Update changelog and deprecated config checker
Browse files Browse the repository at this point in the history
  • Loading branch information
salvacorts committed Jan 12, 2024
1 parent 2d3303a commit ab53968
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
* [10959](https://github.com/grafana/loki/pull/10959) **slim-bean** introduce a backoff wait on subquery retries.
* [11121](https://github.com/grafana/loki/pull/11121) **periklis** Ensure all lifecycler cfgs ref a valid IPv6 addr and port combination
* [10650](https://github.com/grafana/loki/pull/10650) **matthewpi** Ensure the frontend uses a valid IPv6 addr and port combination
* [11665](https://github.com/grafana/loki/pull/11665) **salvacorts** Deprecate and flip `-legacy-read-mode` flag to `false` by default.

#### Promtail

Expand Down
1 change: 1 addition & 0 deletions docs/sources/setup/upgrade/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ This new metric will provide a more clear signal that there is an issue with ing
| `querier.tsdb-max-query-parallelism` | 128 | 512 | - |
| `query-scheduler.max-outstanding-requests-per-tenant` | 32000 | 100 | - |
| `validation.max-label-names-per-series` | 15 | 30 | - |
| `legacy-read-mode` | false | true | Deprecated. It will be removed in the next minor release. |
{{% /responsive-table %}}

#### Write dedupe cache is deprecated
Expand Down
1 change: 1 addition & 0 deletions tools/deprecated-config-checker/checker/checker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ var (
}

expectedConfigDeprecates = []string{
"legacy-read-mode",
"ruler.remote_write.client",
"index_gateway.ring.replication_factor",
"storage_config.bigtable",
Expand Down
1 change: 1 addition & 0 deletions tools/deprecated-config-checker/deprecated-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# _msg: "Use tsdb (preferred) or boltdb-shipper instead."
#
# Note that even though the configs in schema_config takes a list, here we specify the deprecated fields for each item in the list.
legacy-read-mode: "Legacy read SSD mode is deprecated and will be eventually removed. Use the new read and backend targets."

ruler:
remote_write:
Expand Down
1 change: 1 addition & 0 deletions tools/deprecated-config-checker/test-fixtures/config.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
auth_enabled: false
legacy-read-mode: true

server:
http_listen_port: 3100
Expand Down

0 comments on commit ab53968

Please sign in to comment.