Represent bytes only as B

grafana · Nov 20, 2023 · 259a4d5 · 259a4d5
1 parent eaac0fb
commit 259a4d5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/pkg/logql/log/label_filter.go b/pkg/logql/log/label_filter.go
@@ -5,7 +5,6 @@ import (
 	"strconv"
 	"strings"
 	"time"
-	"unicode"
 
 	"github.com/dustin/go-humanize"
 	"github.com/prometheus/prometheus/model/labels"
@@ -214,13 +213,7 @@ func (d *BytesLabelFilter) RequiredLabelNames() []string {
 }
 
 func (d *BytesLabelFilter) String() string {
-	b := strings.Map(func(r rune) rune {
-		if unicode.IsSpace(r) {
-			return -1
-		}
-		return r
-	}, humanize.Bytes(d.Value)) // TODO: discuss whether this should just be bytes, B, to be more accurate.
-	return fmt.Sprintf("%s%s%s", d.Name, d.Type, b)
+	return fmt.Sprintf("%s%s%dB", d.Name, d.Type, d.Value)
 }
 
 type DurationLabelFilter struct {

diff --git a/pkg/logql/syntax/parser_test.go b/pkg/logql/syntax/parser_test.go
@@ -2014,7 +2014,7 @@ var ParseTestCases = []struct {
 			MultiStages: MultiStageExpr{
 				newLabelParserExpr(OpParserTypeJSON, ""),
 				&LabelFilterExpr{
-					LabelFilterer: log.NewBytesLabelFilter(log.LabelFilterGreaterThanOrEqual, "size", 2_748_779_070),
+					LabelFilterer: log.NewBytesLabelFilter(log.LabelFilterGreaterThanOrEqual, "size", 2_748_779_069),
 				},
 			},
 		},