Skip to content

Commit

Permalink
Pass --build-arg to docker-driver build command (#11379)
Browse files Browse the repository at this point in the history
This fixes an issue with the build system when the Go version is updated
in the build image and go.mod relies on the new features of the Go
version.

See failed CI run https://drone.grafana.net/grafana/loki/31777/28/2

Signed-off-by: Christian Haudum <[email protected]>
(cherry picked from commit 856b573)
  • Loading branch information
chaudum authored and sandeepsukhani committed Dec 4, 2023
1 parent 4da48bc commit 1da11e9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ PLUGIN_ARCH ?=
define build-rootfs
rm -rf clients/cmd/docker-driver/rootfs || true
mkdir clients/cmd/docker-driver/rootfs
docker build -t rootfsimage -f clients/cmd/docker-driver/Dockerfile .
docker build --build-arg $(BUILD_IMAGE) -t rootfsimage -f clients/cmd/docker-driver/Dockerfile .

ID=$$(docker create rootfsimage true) && \
(docker export $$ID | tar -x -C clients/cmd/docker-driver/rootfs) && \
Expand Down
2 changes: 1 addition & 1 deletion clients/cmd/docker-driver/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BUILD_IMAGE=grafana/loki-build-image:0.29.3
ARG BUILD_IMAGE=grafana/loki-build-image:0.31.2
# Directories in this file are referenced from the root of the project not this folder
# This file is intended to be called from the root like so:
# docker build -t grafana/loki -f cmd/loki/Dockerfile .
Expand Down

0 comments on commit 1da11e9

Please sign in to comment.