Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max duration calculations with multiple 0 vus stages at end #2573

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix max duration calculations with multiple 0 vus stages at end #2573

wants to merge 4 commits into from

Commits on Jun 15, 2022

  1. Fix max duration calculations with multiple 0 vus stages at end 

    In b725f03 we fixed the calculation of the stages, unfortunately we
didn't notice that the max duration for the test was wrongly calculated.

This also tries to fix cases where graceful* will extend the test more
then needed. Previously the code did not take into account that multiple
0 VUs stages can mean that the VUs are long ago stopped before
gracefulStop (for example) needs to be taken into account.
    @mstoykov
    mstoykov committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    a0ac791 View commit details
    Browse the repository at this point in the history

  2. Don't extend the duration if gracefulStop will not do anything

    @mstoykov
    mstoykov committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    7d27047 View commit details
    Browse the repository at this point in the history

  3. Remove commented code

    @mstoykov
    mstoykov committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    f0cc28f View commit details
    Browse the repository at this point in the history

  4. Add more comments

    @mstoykov
    mstoykov committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    dbb6f50 View commit details
    Browse the repository at this point in the history