Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSQ mixin #719

Merged
merged 9 commits into from
Jan 18, 2022
Merged

NSQ mixin #719

merged 9 commits into from
Jan 18, 2022

Conversation

v-zhuravlev
Copy link
Contributor

@v-zhuravlev v-zhuravlev commented Jan 12, 2022

This PR introduces NSQ mixin.
NSQ exposes metrics via statsd, so Grafana agent/statsd_exporter required so get metrics into Prometheus.

This NSQ mixin interesting features:

  1. Set of two dashboards:
    NSQ Topics - view metrics grouped by topics and channels
    screenshot-0
    NSQ Instances - view metrics grouped by nsqd instances
    screenshot-1

  2. Dashboard links to quickly jump from one dashboard(view) to another.

  3. Data links to contextually jump from instance view to topics view and vice versa
    image

  4. Alerts for topics and channel depth.
    image

In order to test this mixin with live data, please use sample app in dev environment.

add topic metrics
repeat topics panels
- set of two dashboards
- nsqgrafonnet timeseries panel used
@v-zhuravlev v-zhuravlev changed the title WIP: NSQ mixin NSQ mixin Jan 14, 2022
@v-zhuravlev v-zhuravlev marked this pull request as ready for review January 14, 2022 15:19
Copy link
Contributor

@rgeyer rgeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small nits about formatting, but nothing that should block this if you do not agree with my comments.

Excellent work. Thank you!

nsq-mixin/README.md Show resolved Hide resolved
nsq-mixin/dashboards/instances.libsonnet Outdated Show resolved Hide resolved
nsq-mixin/dashboards/topics.libsonnet Show resolved Hide resolved
local prometheus = grafana.prometheus;

{
new(title, description=null)::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I'll likely use it in some of my future mixins.

Do we anticipate building more of these for other newer visualizations?

Do we think that it makes sense to offer this upstream to grafonnet, or as a separate extension library?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though there concerns about grafonnet lib(grafana/grafonnet-lib#332), I think we should use some time to update grafonnet upstream.

@v-zhuravlev v-zhuravlev merged commit a297fc2 into master Jan 18, 2022
@v-zhuravlev v-zhuravlev deleted the vzhuravlev/nsq-mixin branch January 18, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants