Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Add support for timeseries panels #362

Closed
wants to merge 2 commits into from
Closed

Conversation

rhowe
Copy link
Contributor

@rhowe rhowe commented Jul 31, 2022

This is based on the behaviour of Grafana 9.0.5

It should address #358 and #352

Upgrade the e2e tests to work with Grafana 9.x

  • jsonnet to 18
  • cypress to 10.9
  • grafana to 9.2.1

Fixes #363

Note that I haven't used cypress before and I work hard to avoid node, so this might not be quite right.

I added a Makefile target for running npm install to allow upgrading Cypress without relying on a local Nodejs install.

Somehow I missed the fact the repo had tests until I was too far down the rabbit hole writing the tests in a different style, hope that's OK.

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2022

CLA assistant check
All committers have signed the CLA.

@rhowe rhowe force-pushed the add-timeseries branch 6 times, most recently from 96844c0 to 1f9f002 Compare August 7, 2022 08:11
@rhowe rhowe force-pushed the add-timeseries branch 2 times, most recently from 8d3c2cc to 0e5f0bd Compare August 18, 2022 09:17
@rhowe
Copy link
Contributor Author

rhowe commented Sep 20, 2022

@malcolmholmes sorry to be a pain, and I know grafonnet isn't exactly an active project these days but what are the chances of this PR getting a review?

@nickkjolsing
Copy link

@rhowe Agreed, I would absolutely love having timeseries compatibility :)

@joaosa
Copy link

joaosa commented Sep 29, 2022

@malcolmholmes same here! this would be incredibly useful

@rhowe
Copy link
Contributor Author

rhowe commented Sep 29, 2022

If you want this, please don't continue to spam a Grafana engineer with comments (yes, OK, I know, I started it, but we don't all need to do it). Just add a 👍 to the MR

Also there's nothing stopping you taking the code from my branch and using it yourself, even if it's not in the main grafonnet repo.

@rhowe rhowe force-pushed the add-timeseries branch 2 times, most recently from f1b7e21 to 446015b Compare September 30, 2022 20:02
@rhowe rhowe force-pushed the add-timeseries branch 2 times, most recently from b020d8f to f7d5097 Compare October 9, 2022 08:30
- jsonnet to 18
- cypress to 10.9
- grafana to 9.2.1
@rhowe rhowe force-pushed the add-timeseries branch 2 times, most recently from a334037 to 9b935b5 Compare October 23, 2022 09:01
This is based on the behaviour of Grafana 9.0.5
@malcolmholmes
Copy link
Contributor

See new README. This repo is deprecated. The new Grafonnet has support for the timeseries panel (https://github.com/grafana/grafonnet)

@rhowe rhowe deleted the add-timeseries branch June 18, 2023 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e tests fail with grafana 9.x
6 participants