Fix: GrafanaDashboard incorrect NoMatchingInstances

[Baarsgaard]

This is a not so simple fix for #1164
Inspiration was taken from the GrafanaContactPoint but this moves more instance checking logic into the GetMatchingDashboardInstances function

kubectl get grafanadashboards.grafana.integreatly.org -n test
NAME                   NO MATCHING INSTANCES   LAST RESYNC   AGE
cross-namespace                                1s            54m
cross-namespace-fail   true                    4m6s          54m

Test resources

Should result in logs like:
2024-11-09T19:33:43Z ERROR GrafanaDashboardReconciler could not find matching instances {"name": "cross-namespace-fail", "error": "no matching instances"}

---
apiVersion: v1
kind: Namespace
metadata:
  name: test
---
apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaDashboard
metadata:
  name: cross-namespace-fail
  namespace: test
spec:
  folder: General
  allowCrossNamespaceImport: true
  resyncPeriod: 10s
  instanceSelector:
    matchLabels:
      grafana: "dashboards"
  json: >
    {
      "annotations": {
        "list": [
          {
            "builtIn": 1,
            "datasource": {
              "type": "grafana",
              "uid": "-- Grafana --"
            },
            "enable": true,
            "hide": true,
            "iconColor": "rgba(0, 211, 255, 1)",
            "name": "Annotations & Alerts",
            "type": "dashboard"
          }
        ]
      },
      "editable": true,
      "fiscalYearStartMonth": 0,
      "graphTooltip": 0,
      "links": [],
      "panels": [
        {
          "datasource": {
            "type": "grafana-testdata-datasource",
            "uid": "grafana-testdata"
          },
          "fieldConfig": {
            "defaults": {
              "color": {
                "mode": "thresholds"
              },
              "custom": {
                "align": "auto",
                "cellOptions": {
                  "type": "auto"
                },
                "inspect": false
              },
              "mappings": [],
              "thresholds": {
                "mode": "absolute",
                "steps": [
                  {
                    "color": "green",
                    "value": null
                  },
                  {
                    "color": "red",
                    "value": 80
                  }
                ]
              }
            },
            "overrides": [
              {
                "matcher": {
                  "id": "byName",
                  "options": "id"
                },
                "properties": [
                  {
                    "id": "custom.width",
                    "value": 72
                  }
                ]
              }
            ]
          },
          "gridPos": {
            "h": 8,
            "w": 24,
            "x": 0,
            "y": 0
          },
          "id": 2,
          "options": {
            "cellHeight": "sm",
            "footer": {
              "countRows": false,
              "fields": "",
              "reducer": [
                "sum"
              ],
              "show": false
            },
            "showHeader": true,
            "sortBy": []
          },
          "pluginVersion": "10.4.3",
          "targets": [
            {
              "datasource": {
                "type": "grafana-testdata-datasource",
                "uid": "grafana-testdata"
              },
              "refId": "A",
              "scenarioId": "grafana_api",
              "stringInput": "datasources"
            }
          ],
          "title": "Panel Title",
          "type": "table"
        },
        {
          "datasource": {
            "type": "grafana-testdata-datasource",
            "uid": "grafana-testdata"
          },
          "fieldConfig": {
            "defaults": {
              "color": {
                "mode": "thresholds"
              },
              "custom": {
                "align": "auto",
                "cellOptions": {
                  "type": "auto"
                },
                "inspect": false
              },
              "mappings": [],
              "thresholds": {
                "mode": "absolute",
                "steps": [
                  {
                    "color": "green",
                    "value": null
                  },
                  {
                    "color": "red",
                    "value": 80
                  }
                ]
              }
            },
            "overrides": []
          },
          "gridPos": {
            "h": 7,
            "w": 24,
            "x": 0,
            "y": 8
          },
          "id": 1,
          "options": {
            "cellHeight": "sm",
            "footer": {
              "countRows": false,
              "fields": "",
              "reducer": [
                "sum"
              ],
              "show": false
            },
            "showHeader": true
          },
          "pluginVersion": "10.4.3",
          "targets": [
            {
              "datasource": {
                "type": "grafana-testdata-datasource",
                "uid": "grafana-testdata"
              },
              "hide": false,
              "refId": "A",
              "scenarioId": "grafana_api",
              "stringInput": "search"
            }
          ],
          "title": "Panel Title",
          "type": "table"
        }
      ],
      "schemaVersion": 39,
      "tags": [],
      "templating": {
        "list": []
      },
      "time": {
        "from": "now-6h",
        "to": "now"
      },
      "timepicker": {},
      "timezone": "browser",
      "title": "Failure",
      "version": 0,
      "weekStart": ""
    }
---
apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaDashboard
metadata:
  name: cross-namespace
  namespace: test
spec:
  folder: General
  allowCrossNamespaceImport: true
  resyncPeriod: 10s
  instanceSelector:
    matchLabels:
      test: "testdata"
  json: >
    {
      "annotations": {
        "list": [
          {
            "builtIn": 1,
            "datasource": {
              "type": "grafana",
              "uid": "-- Grafana --"
            },
            "enable": true,
            "hide": true,
            "iconColor": "rgba(0, 211, 255, 1)",
            "name": "Annotations & Alerts",
            "type": "dashboard"
          }
        ]
      },
      "editable": true,
      "fiscalYearStartMonth": 0,
      "graphTooltip": 0,
      "links": [],
      "panels": [
        {
          "datasource": {
            "type": "grafana-testdata-datasource",
            "uid": "grafana-testdata"
          },
          "fieldConfig": {
            "defaults": {
              "color": {
                "mode": "thresholds"
              },
              "custom": {
                "align": "auto",
                "cellOptions": {
                  "type": "auto"
                },
                "inspect": false
              },
              "mappings": [],
              "thresholds": {
                "mode": "absolute",
                "steps": [
                  {
                    "color": "green",
                    "value": null
                  },
                  {
                    "color": "red",
                    "value": 80
                  }
                ]
              }
            },
            "overrides": [
              {
                "matcher": {
                  "id": "byName",
                  "options": "id"
                },
                "properties": [
                  {
                    "id": "custom.width",
                    "value": 72
                  }
                ]
              }
            ]
          },
          "gridPos": {
            "h": 8,
            "w": 24,
            "x": 0,
            "y": 0
          },
          "id": 2,
          "options": {
            "cellHeight": "sm",
            "footer": {
              "countRows": false,
              "fields": "",
              "reducer": [
                "sum"
              ],
              "show": false
            },
            "showHeader": true,
            "sortBy": []
          },
          "pluginVersion": "10.4.3",
          "targets": [
            {
              "datasource": {
                "type": "grafana-testdata-datasource",
                "uid": "grafana-testdata"
              },
              "refId": "A",
              "scenarioId": "grafana_api",
              "stringInput": "datasources"
            }
          ],
          "title": "Panel Title",
          "type": "table"
        },
        {
          "datasource": {
            "type": "grafana-testdata-datasource",
            "uid": "grafana-testdata"
          },
          "fieldConfig": {
            "defaults": {
              "color": {
                "mode": "thresholds"
              },
              "custom": {
                "align": "auto",
                "cellOptions": {
                  "type": "auto"
                },
                "inspect": false
              },
              "mappings": [],
              "thresholds": {
                "mode": "absolute",
                "steps": [
                  {
                    "color": "green",
                    "value": null
                  },
                  {
                    "color": "red",
                    "value": 80
                  }
                ]
              }
            },
            "overrides": []
          },
          "gridPos": {
            "h": 7,
            "w": 24,
            "x": 0,
            "y": 8
          },
          "id": 1,
          "options": {
            "cellHeight": "sm",
            "footer": {
              "countRows": false,
              "fields": "",
              "reducer": [
                "sum"
              ],
              "show": false
            },
            "showHeader": true
          },
          "pluginVersion": "10.4.3",
          "targets": [
            {
              "datasource": {
                "type": "grafana-testdata-datasource",
                "uid": "grafana-testdata"
              },
              "hide": false,
              "refId": "A",
              "scenarioId": "grafana_api",
              "stringInput": "search"
            }
          ],
          "title": "Panel Title",
          "type": "table"
        }
      ],
      "schemaVersion": 39,
      "tags": [],
      "templating": {
        "list": []
      },
      "time": {
        "from": "now-6h",
        "to": "now"
      },
      "timepicker": {},
      "timezone": "browser",
      "title": "Matching",
      "version": 0,
      "weekStart": ""
    }

[Baarsgaard]

Having looked at a lot of the controllers over the last few weeks, I've noticed that there's little to no consistency in setting conditions and NoMatchingInstances.
Any reconciler using the shared setNoMatchingInstances function never sets the status.NoMatchingInstances flag or their status is lacking it outright.
It might make sense to refactor getMatchingInstances and the status specs handling before more changes are planned.
I'm specifically referring to the following issues:

• Add status conditions to all objects #1450
• Improve logging of resource sync #1570
• Add finalizers to all resources #1678
• [Bug] Reduce event storm when resyncPeriod is low #1220