Add deb and rpm package upgrade validation #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kminehart
requested changes
Jul 6, 2023
Co-authored-by: Kevin Minehart <[email protected]>
Co-authored-by: Kevin Minehart <[email protected]>
Co-authored-by: Kevin Minehart <[email protected]>
kminehart
requested changes
Jul 7, 2023
kminehart
approved these changes
Jul 11, 2023
pipelines/package_validate.go
Outdated
Comment on lines
248
to
254
| return fmt.Errorf("license in package does not match edition in package name") | ||
| } | ||
| } | ||
|
|
||
| if taropts.Edition == "" { | ||
| if err != nil || !strings.Contains(license, "GNU AFFERO GENERAL PUBLIC LICENSE") { | ||
| return fmt.Errorf("failed to validate open-source license") | ||
| if !strings.Contains(license, "GNU AFFERO GENERAL PUBLIC LICENSE") { | ||
| return fmt.Errorf("license in package does not match edition in package name") |
There was a problem hiding this comment.
in these contexts we know what to expect; we should be clearer about what we expect vs what was given. "license in package is not the Grafana Enterprise license agreement", for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.