Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively moves what is in
pipelines/pro_image.go
from this PR into the declarative model that was added here.Some external projects still depend on that old command so those need to be updated before the
pro_image.go
pipeline and pro-image commands can be removed.The benefit of using the declarative model in this case is that we can build the pro image along with every other artifact, and they will reuse the same cloned repositories, compiled frontend, etc.
Example:
Because they both use the same compiled frontend, it'll only be compiled once and reused for all artifacts.
And because the pro docker image depends on the pro deb, the pro deb will be built first and given to the pro docker image.
Requirements
The
main
branch ofgrafana-build
should be compatible with all active versions of Grafana and Grafana-Enterprise.main
in Grafana.main
in Grafana Enterprise.I also tested the
docker
artifacts with the--verify
command (and with the Dockerfile in this project). Everything looks good!