Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarballs: Check if version contains build ID #187

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

dsotirakis
Copy link
Contributor

Reverts last change (#186) due to https://drone.grafana.net/grafana/grafana/137439/5/11 - 2023/09/28 10:19:37 Got version 10.2.0-, which is a non-semver compatible version, thus lerna fails.

This PR checks if the build ID is already part of the version string - if it is then don't re-add it. If it's not then add.

@dsotirakis dsotirakis requested a review from a team September 28, 2023 10:41
@dsotirakis dsotirakis self-assigned this Sep 28, 2023
@dsotirakis dsotirakis enabled auto-merge (squash) September 28, 2023 10:42
@dsotirakis dsotirakis merged commit 71af960 into main Sep 28, 2023
3 checks passed
@dsotirakis dsotirakis deleted the fix-tarball-name-v2 branch September 28, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants