Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add opentelemetry support #157

Merged
merged 3 commits into from
Sep 12, 2023
Merged

feat: Add opentelemetry support #157

merged 3 commits into from
Sep 12, 2023

Conversation

zerok
Copy link
Contributor

@zerok zerok commented Sep 11, 2023

This adds basic support for OTEL traces to grafana-build. The main idea is to have at least one top-level span per pipeline (pipeline-<CMD-NAME>) with further sub-spans coming in where needed.

Supported is also the TRACEPARENT environment variable which is set by otel-cli and others. This could be used for instance within the main Drone pipeline for Grafana, wrapping the calls to the various scripts so that we have a single parent span for all these grafana-build executions in there.

Screenshot 2023-09-11 at 12 04 13

@zerok zerok added the enhancement New feature or request label Sep 11, 2023
@zerok zerok requested a review from a team September 11, 2023 09:01
Copy link
Collaborator

@kminehart kminehart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. if you feel like addressing the two comments I made you can or you can leave them, nbd either way. Thanks for adding this! can't wait to use it :D

pipelines/pipeline_args.go Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
@zerok zerok merged commit a8618f5 into main Sep 12, 2023
3 checks passed
@zerok zerok deleted the zerok/otel-support branch September 12, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants