Allow alloy_user_groups variable again #276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 8dbd124 broke grafana#212, see comments: - grafana#212 (comment) - grafana#209 (comment)
pjezek
requested review from
ishanjainn,
v-zhuravlev and
gardar
as code owners
|
|
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Please review this change:
The
{{ [ service_group ] + alloy_user_groups }was replaced to{{ alloy_service_group }}instead of{{ [ alloy_service_group ] + alloy_user_groups }}in c9000d1106232916440b7d26c7da8f98fb5367b2.Commit c9000d1106232916440b7d26c7da8f98fb5367b2 broke #212
see comments:
Thanks and have a nice day.