Fix: promtail and loki check mode #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjvengelen
approved these changes
Sep 11, 2024
|
@ishanjainn, could you please review this when you have a moment? Thank you! 🚀 |
voidquark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
The original PR #266 appears to be on hold, due to not signing the Contributor License Agreement (CLA). Additionally, it seems to be lacking some necessary changes for Loki and Promtail.
What Does This PR Change?
I tested Promtail and Loki in check mode and verified that it works on fresh systems where neither Loki nor Promtail is installed. This PR ensures that you can run check mode for both Promtail and Loki.