Drop curl check #120
Merged
Drop curl check #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curl is required on localhost, not target host. This check could fail the playbook, if curl is missing on remote host (where it is actually not needed). Decided not to reimplement this check on ansible controller, as it may be not that easy (if you run ansible controller on MacOS or in containers).
|
Hey @v-zhuravlev |
|
It is not: It used on localhost (ansible controller) only. |
|
Ahh, Should had seen further, Thanks for catching this! |
ishanjainn
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curl is required on localhost, not target host. This check could fail the playbook, if curl is missing on remote host (where it is actually not needed).
Decided not to reimplement this check on ansible controller, as it may be not that easy (if you run ansible controller on MacOS or in containers).