Fix ansible linting issues #544
cardasacAnnotations
20 errors and 12 warnings
|
Perform Linting:
roles/grafana_agent/tasks/ga-started.yaml#L2
2:9 [colons] too many spaces after colon
|
|
Perform Linting:
roles/grafana_agent/tasks/ga-started.yaml#L18
18:3 [indentation] wrong indentation: expected 4 but found 2
|
|
Perform Linting:
changelogs/changelog.yaml#L18
18:7 [indentation] wrong indentation: expected 8 but found 6
|
|
Perform Linting:
changelogs/changelog.yaml#L27
27:7 [indentation] wrong indentation: expected 8 but found 6
|
|
Perform Linting:
changelogs/changelog.yaml#L48
48:7 [indentation] wrong indentation: expected 8 but found 6
|
|
Perform Linting:
changelogs/changelog.yaml#L57
57:7 [indentation] wrong indentation: expected 8 but found 6
|
|
Perform Linting:
changelogs/changelog.yaml#L60
60:7 [indentation] wrong indentation: expected 8 but found 6
|
|
Perform Linting:
changelogs/changelog.yaml#L62
62:7 [indentation] wrong indentation: expected 8 but found 6
|
|
Perform Linting:
changelogs/changelog.yaml#L69
69:7 [indentation] wrong indentation: expected 8 but found 6
|
|
Perform Linting:
changelogs/changelog.yaml#L75
75:7 [indentation] wrong indentation: expected 8 but found 6
|
|
schema[changelog]:
changelogs/changelog.yaml#L1
$.releases.4.0.0.changes.minor_changes[5] {'fix': 'Apply correct uid + gid for imported dashboards by @hypery2k in https://github.com/grafana/grafana-ansible-collection/pull/167'} is not of type 'string'. See https://github.com/ansible-community/antsibull-changelog/blob/main/docs/changelog.yaml-format.md
|
|
meta-runtime[unsupported-version]:
meta/runtime.yml#L1
'requires_ansible' key must refer to a currently supported version such as: >=2.15.0, >=2.16.0, >=2.17.0
|
|
command-instead-of-shell:
roles/alloy/tasks/ga-started.yml#L18
Use shell only when shell functionality is required.
|
|
no-handler:
roles/alloy/tasks/install.yml#L29
Tasks that run when changed should likely be handlers.
|
|
risky-file-permissions:
roles/grafana/tasks/configure.yml#L89
File permissions unset or incorrect.
|
|
command-instead-of-shell:
roles/grafana_agent/tasks/ga-started.yaml#L18
Use shell only when shell functionality is required.
|
|
risky-shell-pipe:
roles/grafana_agent/tasks/preflight/download.yaml#L5
Shells that use pipes should set the pipefail option.
|
|
risky-shell-pipe:
roles/grafana_agent/tasks/preflight/install.yaml#L55
Shells that use pipes should set the pipefail option.
|
|
var-naming[no-role-prefix]:
roles/grafana_agent/vars/main.yaml#L6
Variables names from within roles should use grafana_agent_ as a prefix. (vars: _download_cpu_arch_map)
|
|
var-naming[no-role-prefix]:
roles/mimir/defaults/main.yml#L13
Variables names from within roles should use mimir_ as a prefix. (vars: arch_mapping)
|
|
Perform Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Perform Linting:
roles/opentelemetry_collector/tasks/configure.yml#L1
1:1 [document-start] missing document start "---"
|
|
Perform Linting:
roles/opentelemetry_collector/tasks/install.yml#L1
1:1 [document-start] missing document start "---"
|
|
Perform Linting:
roles/opentelemetry_collector/tasks/install.yml#L54
54:17 [truthy] truthy value should be one of [false, true]
|
|
Perform Linting:
roles/opentelemetry_collector/tasks/main.yml#L1
1:1 [document-start] missing document start "---"
|
|
Perform Linting:
roles/opentelemetry_collector/tasks/service.yml#L1
1:1 [document-start] missing document start "---"
|
|
Perform Linting:
roles/opentelemetry_collector/tasks/service.yml#L11
11:20 [truthy] truthy value should be one of [false, true]
|
|
Perform Linting:
roles/opentelemetry_collector/tasks/service.yml#L17
17:14 [truthy] truthy value should be one of [false, true]
|
|
Perform Linting:
roles/opentelemetry_collector/meta/main.yml#L1
1:1 [document-start] missing document start "---"
|
|
Perform Linting:
roles/opentelemetry_collector/handlers/main.yml#L1
1:1 [document-start] missing document start "---"
|
|
Perform Linting:
roles/opentelemetry_collector/defaults/main.yml#L1
1:1 [document-start] missing document start "---"
|
|
jinja[spacing]:
roles/grafana_agent/tasks/install/user-group.yaml#L32
Jinja2 spacing could be improved: {{ [ grafana_agent_user_group ] + grafana_agent_user_groups }} -> {{ \[grafana_agent_user_group] + grafana_agent_user_groups }}
|