flagext: Add new type URLEscaped
#265
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we need to store just escaped URL in the config like S3 URL that contains credentials which can include characters like `:` and `/`. Currently we cannot use normal `flagext.URLValue` as it just uses unescaped URL. Please check issue grafana/loki#1607
kavirajk
added a commit
to grafana/loki
that referenced
this pull request
Feb 7, 2023
Fixes: #1607 Introduced this type in another PR grafana/dskit#265
5 tasks
|
Is this work around for properly formatting strings in YAML file? |
Kinda. So basically user should be able to give unescaped S3 bucket URL in both yaml config and as a CLI flag. Our internal dependency Trying to transparenly handle this case. But realized it's hard to do it in backward compatible way. e.g: If people already working with escaped URL. Tried few things but looks bit tricky. Converting to draft PR till I find right way to do it. |
Signed-off-by: Kaviraj <[email protected]>
charleskorn
pushed a commit
that referenced
this pull request
Aug 3, 2023
Make gogo.proto import vendoring agnostic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Sometimes we need to store just escaped URL in the config like S3 URL that contains credentials which can include characters like
:and/. Currently we cannot use normalflagext.URLValueas it just uses unescaped URL.Please check issue
grafana/loki#1607
Which issue(s) this PR fixes:
Fixes grafana/loki#1607
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]